Here are my thoughts on the topic.
I think in order to be successful with display advertising, you have to have A LOT of traffic to your site. Realistically, for most people it just isn't feasible, due to the sheer amount of work involved in getting your site to the point where it can be profitable for you in any kind of substantial way. Although, this is definitely the easiest route to take.
Of the three, I think your best bet for making a substantial amount of money is affiliate marketing. There are an unlimited amount of ways you can be successful in this, but there are people that make a LOT of money doing this (like millions of dollars annually). However there is also a big difference between putting up one affiliate link to someones ebook on your blog, versus spending 16 hours a day doing keyword research, split testing and risking thousands of dollars in cpc or cpm affiliate marketing. If you are serious about making substantial money and are a bit of a risk taker, this would be the way to go. And frankly, even including basic affiliate links on your site to informational products will probably yield better results than advertising in most cases.
Direct sales, in my mind this is in the middle of the other two. If you have some knowledge that you could impart on others in a useful and interesting way, creating an informational product of some sort, is a great route to take. You won't make millions, but there are definitely people out there making some decent income from their products. You also have the benefit of being able to create it and forget it (more or less) to get income for an indefinite period of time.
By using a combination of all three, or at least understanding the basic concepts of all three, you will increase your chances of success by figuring out what works for you!
Hope this was useful!